This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Conversation
Author
Btw this time we upgraded rust version and many low level libraries. So for now better only testing this branch, later we will pick some needed changes to v0.13 for dual version support.. |
lispc
reviewed
Nov 7, 2024
| /// accumulator. | ||
| /// | ||
| /// Every SNARK layer on top of the [`innermost layer`][LayerId::Inner] has an accumulator. | ||
| pub fn accumulator(&self) -> bool { |
Author
There was a problem hiding this comment.
It is a planned change. I have not yet removed the has_accumulator argument from function calls.
lispc
approved these changes
Nov 7, 2024
|
i will help with e2e testing. |
|
need to change to BatchProofV2? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor the
provercrate for:Notice
Requires re-running e2e tests and debugging potentially regression issues in the
provercrate's behaviour:scroll-prover: https://github.com/scroll-tech/scroll-proverscroll/prover: https://github.com/scroll-tech/scroll/tree/develop/prover